Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Migrate CLI to Salsa #11972

Draft
wants to merge 1 commit into
base: alias-has-type
Choose a base branch
from

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 21, 2024

Summary

Still very much in process.

This PR updates the red-knot CLI to use the new Salsa based semantic model.

What's missing:

  • Eager scheduling of dependencies for concurrent analysis
  • Handling file system changes

Test Plan

[crates/red_knot/src/main.rs:173:21] diagnostics = [
    "Unresolved import 'Base1'",
    "Method A.foo is decorated with `typing.override` but does not override any base class method",
]

@MichaReiser MichaReiser changed the base branch from main to alias-has-type June 21, 2024 16:15
@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Jun 21, 2024
@MichaReiser MichaReiser force-pushed the alias-has-type branch 4 times, most recently from 19af3c4 to cf46aac Compare June 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant