Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruff] itertools.batched() without explicit strict (RUF054) #14408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14387.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 18, 2024
@MichaReiser
Copy link
Member

I think I prefer to wait with adding this rule and see if it gets accepted upstream to avoid having to re-code in a few days/weeks. See PyCQA/flake8-bugbear#498

@MichaReiser MichaReiser added the needs-decision Awaiting a decision from a maintainer label Nov 19, 2024
@InSyncWithFoo InSyncWithFoo deleted the RUF054 branch November 20, 2024 03:45
@InSyncWithFoo InSyncWithFoo restored the RUF054 branch November 20, 2024 12:28
@InSyncWithFoo InSyncWithFoo reopened this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Awaiting a decision from a maintainer preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: require explicit strict= argument for itertools.batched
3 participants