Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Rust cache before installing binaries and additional components #14459

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 19, 2024

I was hoping to reduce the time spent on binary installs, but unfortunately additional binaries are always reinstalled taiki-e/install-action#577 — unfortunately that increases the cache size.

However, this does cache setup of the Rust toolchain which may save time. Since most of the Rust toolchain installation is just downloading components, and we still need to download the cache, there might not be much time saved here. The benefit is that the cache is generally closer to the runner on the network. Toolchain installation takes ~10s on Linux and >1m on Windows. It looks like there are some nice savings on Windows but it's less clear on Linux. The pre-commit job is 10s faster, but (perhaps due to the bug above) the test job is 8s slower.

@zanieb zanieb added internal An internal refactor or improvement ci Related to internal CI tooling and removed internal An internal refactor or improvement labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb zanieb closed this Nov 19, 2024
@zanieb zanieb reopened this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant