Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-builtins] Exempt private built-in modules (A005) #14505

Merged
merged 2 commits into from
Nov 24, 2024
Merged

[flake8-builtins] Exempt private built-in modules (A005) #14505

merged 2 commits into from
Nov 24, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #12949.

Test Plan

cargo nextest run and cargo insta test.

@InSyncWithFoo
Copy link
Contributor Author

(@AlexWaygood I hope you don't mind me taking over the issue.)

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

mesonbuild/meson-python (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

Failed to pull: fatal: unable to access 'https://github.com/mesonbuild/meson-python/': The requested URL returned error: 504

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 21, 2024
@charliermarsh charliermarsh merged commit 545e9de into astral-sh:main Nov 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A005 (builtin module shadowing) should ignore private modules
3 participants
@InSyncWithFoo @MichaReiser @charliermarsh