Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Understand type[Unknown] #15409

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[red-knot] Understand type[Unknown] #15409

merged 1 commit into from
Jan 10, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Follow-up to #15194.

Test Plan

Markdown tests.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

carljm
carljm approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was going to comment on the previous PR that this should be really easy to fix, but it also seemed like scope creep for that PR. Thanks for following up on it.

@carljm
Copy link
Contributor

carljm commented Jan 10, 2025

I'm not sure what is going on with the fuzzer build here, but it doesn't seem at all related to this PR.

@carljm carljm merged commit 232fbc1 into astral-sh:main Jan 10, 2025
20 of 21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-type-unknown branch January 10, 2025 21:26
@InSyncWithFoo
Copy link
Contributor Author

@carljm winnow just got a new release. Apparently that contains some breaking changes.

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InSyncWithFoo @carljm @dhruvmanila