-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pyflakes
] stabilize raising F822
in __init__.py
files.
#15411
Conversation
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
F822 | 411 | 411 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Thanks. We intended to stabilize this feature as part of 0.8 but realized it's blocked by resolving #12897. We need to resolve this issue before we consider stabilizing it in the next minor. |
@MichaReiser now that #12897 is fixed, would you be open to reopening this PR? |
We tend to wait about a month after the last "significant" change is made to a preview feature before stabilizing it as part of the next minor. I suggest to leave it closed because there's nothing actionable we can do with the PR before we start working on 0.10, which is roughly in 2 months. |
Summary
Stabilize raising
F822
in__init__.py
files.This has been in preview since #11370 which was first released in v0.4.7
Test Plan
Since this is now tested as part of the normal
__init__.py
file test, as seen by the change toruff_linter__rules__pyflakes__tests__init.snap
, I've removed the preview specific one, which would now be redundant.