[red-knot] Support cast
#15413
Merged
[red-knot] Support cast
#15413
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSyncWithFoo
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
|
I think reusing |
AlexWaygood
reviewed
Jan 11, 2025
AlexWaygood
reviewed
Jan 11, 2025
crates/red_knot_python_semantic/resources/mdtest/directives/cast.md
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Jan 11, 2025
crates/red_knot_python_semantic/resources/mdtest/directives/cast.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/directives/cast.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/directives/cast.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Jan 11, 2025
carljm
added a commit
that referenced
this pull request
Jan 13, 2025
## Summary Simplification follow-up to #15413. There's no need to have a dedicated `CallOutcome` variant for every known function, it's only necessary if the special-cased behavior of the known function includes emitting extra diagnostics. For `typing.cast`, there's no such need; we can use the regular `Callable` outcome variant, and update the return type according to the cast. (This is the same way we already handle `len`.) One reason to avoid proliferating unnecessary `CallOutcome` variants is that currently we have to explicitly add emitting call-binding diagnostics, for each outcome variant. So we were previously wrongly silencing any binding diagnostics on calls to `typing.cast`. Fixing this revealed a separate bug, that we were emitting a bogus error anytime more than one keyword argument mapped to a `**kwargs` parameter. So this PR also adds test and fix for that bug. ## Test Plan Existing `cast` tests pass unchanged, added new test for `**kwargs` bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15379.
Test Plan
Markdown tests.