[red-knot] Add Property Tests for Intersection and Union #15415
Merged
+55
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cake-monotone
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
AlexWaygood
added
testing
AlexWaygood
reviewed
Jan 11, 2025
sharkdp
pushed a commit
that referenced
this pull request
Jan 13, 2025
## Summary Follow-up PR from #15415 🥲 The exact same property test already exists: `intersection_assignable_to_both` and `all_type_pairs_can_be_assigned_from_their_intersection` ## Test Plan `cargo test -p red_knot_python_semantic -- --ignored types::property_tests::flaky`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14986
stable tests
all_fully_static_type_pairs_are_subtype_of_their_unionflaky tests
negation_is_disjointall_fully_static_type_pairs_are_supertypes_of_their_unionall_type_pairs_can_be_assigned_from_their_intersectionall_type_pairs_are_assignable_to_their_unionThe tests that are currently failing have been categorized as flaky. The failure of
fully_static_types_are_supertypes_of_their_intersectionseems a bit unusual, so I’ll take look into it and create a separate issue if needed. :)Test Plan
stable:
QUICKCHECK_TESTS=10000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::stableflaky:
QUICKCHECK_TESTS=10000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::flaky