-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for per workspace member locks #1094
base: main
Are you sure you want to change the base?
Conversation
This functionality can be enabled by setting `tools.rye.workspace.per_member_lock` to `true`
The windows test failures are a bit confusing. Failure 1: (link) It seems like uv functions differently in linux/macos and windows. Its reinstalling both workspace members even tho only one of them changed.
The first issue is uv specific, so an update there might be necessary to make it properly consistent |
I missed to see that local_projects was being populated through the loop
Managed to fix the first failure (decf6f9) at the expense of a little bit of overhead that comes from the sorting. I am not sure if its worth it to have reproducible tests in all platforms or not. The second issue is a lot more weird and I find what is determining whether to re-install the project or not in uv. Ill keep investigating |
I have no clue how to debug the last failure. I created a Windows 10 VM to run the tests in and was not even able to reproduce the same failures when running the cargo test or when playing around with uv/rye to attempt to reproduce it installing the editable that was not edited Rye test Windows 10 VM results
|
…_lock` on windows
Decided to disable both tests in windows because I have no clue what is going on (cant even reproduce locally). I kept my project ordering change, because it seems like every other pathlike output in rye is sorted too.
|
- Have a virtual and non-virtual project and ensure that only one is used - This has the "side effect" that the windows CI inconsistencies should no longer occur - Use glob for members matching - Remove redundant pyproject toml edits
I like it. It looks exactly like what I need! When is this PR going to be merged? |
This functionality can be enabled by setting
tools.rye.workspace.per_member_lock
totrue
Added a test for the new functionality as well as one for workspaces on its own (as there didn't seem to be any).
Closes #615
This is my first ever rust pr, so any feedback is welcome and appreciated! If anything needs to be changed, "allow edits by maintainers" is on, or post a comment and I'll change the pr accordingly