New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore freethreaded CPython builds #1437

Merged

zanieb merged 1 commit into astral-sh:main from Alexis-D:bugfix/ignore-freethreaded-builds

Nov 22, 2024

Contributor

Alexis-D commented Nov 22, 2024

Fixes #1436

This seemed like the simplest fix to ignore freethreaded builds.

Couple other thoughts/things that could happen later:

this won't help with folks who already downloaded a 3.13.0 CPython (they'll need to rye toolchain remove [email protected] first, and then fetch it again)
PlatformTriple#flavor should probably be a set[str]; so freethreaded+pgo+lto-full would become {'freethreaded', 'pgo', 'lto'} (tbd what to do with full)


          Ignore freethreaded CPython builds

d6622c7

zanieb approved these changes

View reviewed changes

Member

zanieb left a comment

Awesome thank you!

zanieb merged commit 2d2c6ea into astral-sh:main

8 checks passed

zanieb added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug