Refactor setupPython to use uv python pin & venv setup#291
Refactor setupPython to use uv python pin & venv setup#291Julfried wants to merge 3 commits intoastral-sh:mainfrom
Conversation
|
Thank you for the PR. Unfortunately this issue is a bit tricky. In general we have to decide how much this action should actually do as the name suggest it sets up uv and not more. It currently already does setup a venv in some cases. So we have to decide what the default behavior should be for most users. Please understand that it might take a while for me to fully engage in feedback as this has to be in combination with
|
|
No worries, I just wanted to give this a try and propose a solution for my use case. I completely understand that the scope of That said, I do believe that setting up and activating a Python environment based on the current project should be included—ideally as an optional feature that users can enable if needed. This would make I’d be happy to discuss this further and extend the PR to cover more use cases if that aligns with your vision. Take your time, and thanks again for the feedback :) |
|
Resolved by: #381 Thank you very much for your input! |
This PR attempts to fix the issue where
setup-uvdoes not correctly set up the Python version whenpyproject.tomlis specified and Python should be automatically determined from this file. As described in #283.This is achieved by:
uv python pinto correctly pin Python versions.python-versionto ensureUV_PYTHONis set before activating venvLet me know what you think. Feedback is very welcome :)
Closes #283