Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish from CI #14

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Feb 4, 2025

Also adds a changelog to properly document the changes we made.

Fixes astral-sh/uv#11222

Also adds a changelog to properly document the changes we made.

Fixes astral-sh/uv#11222
@konstin konstin requested a review from charliermarsh February 4, 2025 18:23
Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "astral-tokio-tar"
version = "0.5.0"
version = "0.5.0-rc.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -rc.1?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transplanting comment:

I only bother with prereleases when i need to publish it for testing and there's existing users I don't want to "upgrade" to that version (since cargo makes it an opt-in to ever see prereleases).

I don't see any reason to use that here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually start with a prerelease for new projects so a failed release doesn't get the git tag.

to `false` will still set read, write, and execute permissions on extracted files, but will avoid
setting extended permissions (e.g., `setuid`, `setgid`, and `sticky` bits).
- Avoid creating directories outside the unpack target (see: [`alexcrichton/tar-rs#259`](https://github.com/alexcrichton/tar-rs/pull/259)).
- Added `unpack_in_raw` which memoizes the set of validated paths (and assumes a pre-canonicalized)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up: I renamed this method (because it does a bit more than just memoize).

@charliermarsh charliermarsh enabled auto-merge (squash) February 5, 2025 19:54
@charliermarsh charliermarsh merged commit eec116e into main Feb 5, 2025
3 checks passed
@charliermarsh charliermarsh deleted the konsti/add-publish-ci branch February 5, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please consider publishing astral-tokio-tar on crates.io
3 participants