Repository navigation
Skip existing release artifacts when retrying mirror uploads - #4937
Merged
Merged
Conversation
Use aws s3 sync --no-overwrite so a retry fills missing versioned objects and then reaches the latest installer step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mirror upload can fail after some files for a release have already reached R2. Retrying then attempts to overwrite those immutable objects and can fail again.
This change makes the versioned mirror upload skip existing keys and upload only the missing files. It assumes a retry uses the same release artifacts. An existing file is kept even if its local checksum differs.
Tested against a local S3 server with a partially uploaded release. The first run preserved the existing file and uploaded the missing files. A second run made zero writes.