Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv lock doesn't indicate that it has updated the lock file #4346

Closed
zanieb opened this issue Jun 16, 2024 · 5 comments · Fixed by #5110
Closed

uv lock doesn't indicate that it has updated the lock file #4346

zanieb opened this issue Jun 16, 2024 · 5 comments · Fixed by #5110
Labels
cli Related to the command line interface help wanted Contribution especially encouraged preview Experimental behavior tracing Verbose output and debugging

Comments

@zanieb
Copy link
Member

zanieb commented Jun 16, 2024

The output is just "Resolved ... packages in ...", maybe we should indicate that we've updated the file or locked dependencies?

Even the verbose output doesn't show any indication of updating the lock file.

@zanieb zanieb added tracing Verbose output and debugging preview Experimental behavior labels Jun 16, 2024
@zanieb
Copy link
Member Author

zanieb commented Jun 16, 2024

It'd probably be nice to know if the file was left unchanged or if we updated it.

@kidrahahjo
Copy link

I agree. Would it also make sense to give a brief description of what changed (it can be enabled by default and users would be able to disable it using a --no-summary flag)?

The output command can be

package old version new version action
xyz 1.0.0 ADDED
abc 0.0.1 DELETED
efg 0.1.0 0.1.1 UPDATED

Although this has a downside of a huge output on initial lock creation (and probably more things). Apart from this, for a usual development workflow, teams can always check the diff to see what has changed.

@zanieb
Copy link
Member Author

zanieb commented Jun 17, 2024

Cargo has a nice example here


Updating lockfile...
    Updating uv v0.2.11 (/Users/zb/workspace/uv/crates/uv) -> v0.2.12
    Updating uv-version v0.2.11 (/Users/zb/workspace/uv/crates/uv-version) -> v0.2.12
note: pass `--verbose` to see 102 unchanged dependencies behind latest

@kidrahahjo
Copy link

Yeah, this is a nice inspiration.

I see cargo update --verbose is way less verbose than uv lock --verbose. Do you think we should transition the current verbose flag to very verbose (-vv) and have the verbose flag (-v) for a pretty verbose output?

@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024

We have a tracking issue for that at #1569, we need to do quite a bit of work around our tracing output levels eventually it's just not as high of a priority as the rest of the interface right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface help wanted Contribution especially encouraged preview Experimental behavior tracing Verbose output and debugging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants