Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that uv lock --upgrade has updated the lock file #5110

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

blueraft
Copy link
Contributor

Summary

Resolves #4346, I've gone with the suggested cargo approach here.

Test Plan

cargo test

../target/debug/uv lock --upgrade
warning: `uv lock` is experimental and may change without warning.
Resolved 11 packages in 41ms
Updating flask v2.3.3 -> v3.0.3
note: pass `--verbose` to see 9 unchanged dependencies../target/debug/uv lock --upgrade -vv
    0.002478s DEBUG uv uv 0.2.24
warning: `uv lock` is experimental and may change without warning.
....
Resolved 11 packages in 50ms
    0.103703s DEBUG uv::commands::project::lock Unchanged blinker v1.8.2
    0.103719s DEBUG uv::commands::project::lock Unchanged click v8.1.7
    0.103731s DEBUG uv::commands::project::lock Unchanged colorama v0.4.6
    0.103742s DEBUG uv::commands::project::lock Unchanged flask v3.0.3
    0.103754s DEBUG uv::commands::project::lock Unchanged importlib-metadata v8.0.0
    0.103767s DEBUG uv::commands::project::lock Unchanged itsdangerous v2.2.0
    0.103778s DEBUG uv::commands::project::lock Unchanged jinja2 v3.1.4
    0.103788s DEBUG uv::commands::project::lock Unchanged markupsafe v2.1.5
    0.103798s DEBUG uv::commands::project::lock Unchanged werkzeug v3.0.3
    0.103809s DEBUG uv::commands::project::lock Unchanged zipp v3.19.2

@charliermarsh
Copy link
Member

I got this one.

@charliermarsh charliermarsh self-assigned this Jul 16, 2024
@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality preview Experimental behavior labels Jul 16, 2024
@charliermarsh
Copy link
Member

There's one problem here which is that we can have multiple versions in the new and existing lockfile. I'm not sure what the best logic is here...

@charliermarsh
Copy link
Member

I'll try something a little different.

@charliermarsh charliermarsh enabled auto-merge (squash) July 17, 2024 01:05
@charliermarsh charliermarsh merged commit eb35c05 into astral-sh:main Jul 17, 2024
51 checks passed
@blueraft blueraft deleted the lock-update-log branch July 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv lock doesn't indicate that it has updated the lock file
2 participants