Respect PEP 723 script lockfiles in uv run #10136
Merged
+658
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/script-run
branch
2 times, most recently
from
ae1298c to
786928d
Compare
charliermarsh
force-pushed
the
charlie/script-target
branch
from
1abfeb4 to
f775a80
Compare
charliermarsh
force-pushed
the
charlie/script-run
branch
from
786928d to
8eef27e
Compare
charliermarsh
force-pushed
the
charlie/script-target
branch
from
f775a80 to
a9c8dcb
Compare
charliermarsh
force-pushed
the
charlie/script-run
branch
from
8eef27e to
3067daf
Compare
charliermarsh
force-pushed
the
charlie/script-target
branch
3 times, most recently
from
0095740 to
9ca5fd2
Compare
charliermarsh
removed
no-build
charliermarsh
force-pushed
the
charlie/script-run
branch
from
3067daf to
0b7b597
Compare
charliermarsh
force-pushed
the
charlie/script-run
branch
from
0b7b597 to
e142281
Compare
charliermarsh
force-pushed
the
charlie/script-target
branch
from
9ca5fd2 to
6387028
Compare
charliermarsh
force-pushed
the
charlie/script-run
branch
from
e142281 to
aeb5159
Compare
zanieb
reviewed
Jan 8, 2025
| @@ -200,109 +200,57 @@ pub(crate) async fn run( | |||
| .await? | |||
| .into_interpreter(); | |||
|
|
|||
| // Determine the working directory for the script. | |||
There was a problem hiding this comment.
Feeling like "run script" should live in it's own function at some point
zanieb
approved these changes
Jan 8, 2025
charliermarsh
force-pushed
the
charlie/script-target
branch
from
6387028 to
cede350
Compare
charliermarsh
force-pushed
the
charlie/script-run
branch
from
aeb5159 to
a9adaf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a script has a lockfile, then
uv runwill now reuse it.Closes #7483.
Closes #9688.