Add test coverage for use of git without feature flag
#10874
Conversation
zanieb
force-pushed
the
zb/disable-git
branch
from
e952047 to
dc14fe9
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/disable-git
branch
from
dc14fe9 to
e1e90ce
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/disable-git
branch
3 times, most recently
from
c48e963 to
d71c696
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/disable-git
branch
from
d71c696 to
0b4365a
Compare
zanieb
changed the title
git without feature flag
zanieb
force-pushed
the
zb/disable-git
branch
from
b1eaa9e to
fd318d0
Compare
| let contents = r"#!/bin/sh | ||
| echo 'error: `git` operations are not allowed — are you missing a cfg for the `git` feature?' >&2 | ||
| exit 127"; | ||
| let git = bin_dir.join(format!("git{}", env::consts::EXE_SUFFIX)); | ||
| fs_err::write(&git, contents)?; |
There was a problem hiding this comment.
It's funny, this is all kinds of weird on windows but that's fine because we just need windows to explode (especially because we only need this to break on some platform so the CI throws a fit and tells you to add a cfg).
There was a problem hiding this comment.
Yeah haha it doesn't fail with a nice error message on Windows but it does fail loudly..
There was a problem hiding this comment.
Is there something better we could do that remains trivial?
There was a problem hiding this comment.
I don't think so, especially if anything specifically looks for git.exe (windows PATH resolution is weird and magic about suffixes and there's two different APIs for looking up things on PATH, it's a whole thing).
There was a problem hiding this comment.
(Notably the thing JS does to shim binaries onto path doesn't work with rust's Command because of all this, blech)
Shoves a broken
gitexecutable onto the front of thePATHin the test context when thegitfeature is disabled so they fail if they're missing the feature-gate.