Avoid using owned String in deserializers
#11764
Merged
+350
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/p-1
branch
from
bd1a89f to
1a89d63
Compare
charliermarsh
force-pushed
the
charlie/p-1
branch
from
1a89d63 to
234a6d8
Compare
charliermarsh
force-pushed
the
charlie/p-1
branch
from
234a6d8 to
59dfab4
Compare
charliermarsh
force-pushed
the
charlie/p-1
branch
from
59dfab4 to
0bc745c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the pattern I see in a variety of crates, and I believe this is preferred if you don't need an owned
String, since you can avoid the allocation. This could be pretty impactful for us?