Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Persistent fils logs to testing #11774

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

Choudhry18
Copy link
Contributor

Summary

Adds persistent file logs to snapshot testing that can be viewed later. This builds on to #11762 and attempts to resolve #8351 . This introduces a dedicated log directory that keeps logs from test runs, unless another directory is specified.

Test Plan

I have manually checked if there is a log file for each test file after running the tests. I do believe testing should be a bit more robust, however i am unsure how can that be done - check file logs against cli logs is not easily possible because of print statements in cli.

Discuss

I wanted to get more input on whether there should be log file per command invocation or other other frequency. Currently there is a log file for each test file. To implement one log for each test is quite simple but it requires tediously adding a --log flag to each test.

…ninteded UV_LOG env= shouldn't have the env in front of it
mergin cli_logs into LOG_DIR so can build onto that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show tracing output on test failure
1 participant