-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Persistent fils logs to testing #11774
Open
Choudhry18
wants to merge
31
commits into
astral-sh:main
Choose a base branch
from
Choudhry18:LOG_DIR
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,597
−1,357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making fork up to date
…ninteded UV_LOG env= shouldn't have the env in front of it
Merging main
mergin cli_logs into LOG_DIR so can build onto that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds persistent file logs to snapshot testing that can be viewed later. This builds on to #11762 and attempts to resolve #8351 . This introduces a dedicated log directory that keeps logs from test runs, unless another directory is specified.
Test Plan
I have manually checked if there is a log file for each test file after running the tests. I do believe testing should be a bit more robust, however i am unsure how can that be done - check file logs against cli logs is not easily possible because of print statements in cli.
Discuss
I wanted to get more input on whether there should be log file per command invocation or other other frequency. Currently there is a log file for each test file. To implement one log for each test is quite simple but it requires tediously adding a
--log
flag to each test.