Skip to content

Display dependency versions in pip-like format during solve failure#346

Merged
zanieb merged 2 commits intomainfrom
zanie/equal-disp
Nov 6, 2023
Merged

Display dependency versions in pip-like format during solve failure#346
zanieb merged 2 commits intomainfrom
zanie/equal-disp

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Nov 6, 2023

  • Display == for exact version ranges
  • Remove space between dependency and version range

@zanieb zanieb changed the title Display dependency versions in pi-like format during solve failure Display dependency versions in pip-like format during solve failure Nov 6, 2023
Comment on lines +19 to +20
╰─▶ Because flask ==3.0.0 depends on werkzeug >=3.0.0 and root ==0a0.dev0
depends on flask ==3.0.0, root ==0a0.dev0 is forbidden.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These require the fixes in #342

@zanieb
Copy link
Member Author

zanieb commented Nov 6, 2023

I'm not 100% sure this is better but I do find it clearer?

----- stderr -----
× No solution found when resolving dependencies:
╰─▶ my-project depends on django
╰─▶ my-project depends on django∅
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be displayed per #338

× No solution found when resolving dependencies:
╰─▶ Because flask 3.0.0 depends on werkzeug >=3.0.0 and root 0a0.dev0
depends on flask 3.0.0, root 0a0.dev0 is forbidden.
╰─▶ Because flask ==3.0.0 depends on werkzeug >=3.0.0 and root ==0a0.dev0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these not have spaces?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#342 is needed to use PuffinExternal for those

@zanieb zanieb merged commit 1748cfb into main Nov 6, 2023
@zanieb zanieb deleted the zanie/equal-disp branch November 6, 2023 19:53
zanieb added a commit that referenced this pull request Nov 10, 2023
Follow-up to #346 for some debug messages
zanieb added a commit that referenced this pull request Nov 10, 2023
Follow-up to #346 for some debug
messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants