Fix reflow of index on image load: benchmark image - #6264 #9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Nov 11, 2024
Comment on lines
+91
to
+92
| height: 250px; | ||
| width: 500px; |
There was a problem hiding this comment.
Shouldn't these characteristics be set just for this specific image? Is there a reason you decided to implement it in the general css?
There was a problem hiding this comment.
That's a good suggestion. Initially I wanted to leave the index file unmodified, but I like your suggestion. Here it is.
|
Welcome to the project! |
|
Thanks for the hospitality! |
|
@zanieb Friendly reminder: new commit ready for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a fixed height and width for the benchmark image and description text underneath it.
The purpose of the change is to prevent page reflow and layout shifts on the docs page.
Both light mode and dark mode were tested. The benchmark image is slightly larger with the change. I thought this increase in size helps draw attention to the bolded uv result shown in the benchmark diagram. I'll draw the size back down to the original if reviewers don't like it.
closes #6264