Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(GitLab): add entrypoint for distroless image #9093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tsafaras
Copy link

@Tsafaras Tsafaras commented Nov 13, 2024

Summary

Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.

Test Plan

Without specifying an entrypoint when using a distroless image:

It works if you either specify the entrypoint or if the image used in not a distroless one.

@zanieb
Copy link
Member

zanieb commented Nov 13, 2024

Hm I thought we removed the custom entrypoint in #7054

@Tsafaras
Copy link
Author

Tsafaras commented Nov 13, 2024

This is the image I used:

ghcr.io/astral-sh/uv:python3.8-bookworm

Could this be why? My project is still using that Python version.

But, as you can see from the images I posted, uv's version is latest (0.5.1).
Could also have something to do with GitLab and not with uv.

@Tsafaras
Copy link
Author

@zanieb Friendly reminder.
Let me know how you want to move on this.

@samypr100
Copy link
Collaborator

samypr100 commented Nov 21, 2024

@Tsafaras On your first image example you're using the distroless image which is not supported in Gitlab as sh does not exist in it. That's actually one of the reason the non-distroless images were added 😄

We do not have custom entrypoints on any of the non-distroless images. The distroless does and defaults to uv as it's the only binary in that container image.

e.g.

Non-Distroless

~/ $ docker inspect ghcr.io/astral-sh/uv:0.5-python3.8-bookworm | jq  -r '.[0].Config.Entrypoint'
null

Distroless

~/ $ docker inspect ghcr.io/astral-sh/uv:0.5 | jq  -r '.[0].Config.Entrypoint'
[
  "/uv"
]

@Tsafaras
Copy link
Author

Tsafaras commented Nov 21, 2024

@samypr100 Thank you for the response, especially for the last snippet!
I tried finding something similar as to what you can see on docker hub (example), but I didn't find it on GH's registry. 🤔
In between tests I never considered I had changed the image.

Should I edit the PR to make this change in the relative docs then?

If you're using a distroless image ... blah blah

@samypr100
Copy link
Collaborator

Should I edit the PR to make this change in the relative docs then?

I think it's worth adding a note to the gitlab docs, thanks

Update the docs for the GitLab integration, to make it clear that an entrypoint
has to be specified, when a distroless image is being used.
@Tsafaras
Copy link
Author

@samypr100 @zanieb Turned the correction to a note. Please have a look.

@zanieb zanieb added the documentation Improvements or additions to documentation label Nov 21, 2024
@Tsafaras Tsafaras changed the title Docs: missing entrypoint in gitlab integration Docs(GitLab): add entrypoint for distroless image Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants