-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(GitLab): add entrypoint for distroless image #9093
base: main
Are you sure you want to change the base?
Conversation
Hm I thought we removed the custom entrypoint in #7054 |
This is the image I used:
Could this be why? My project is still using that Python version. But, as you can see from the images I posted, |
@zanieb Friendly reminder. |
@Tsafaras On your first image example you're using the distroless image which is not supported in Gitlab as We do not have custom entrypoints on any of the non-distroless images. The distroless does and defaults to uv as it's the only binary in that container image. e.g. Non-Distroless ~/ $ docker inspect ghcr.io/astral-sh/uv:0.5-python3.8-bookworm | jq -r '.[0].Config.Entrypoint'
null Distroless ~/ $ docker inspect ghcr.io/astral-sh/uv:0.5 | jq -r '.[0].Config.Entrypoint'
[
"/uv"
] |
@samypr100 Thank you for the response, especially for the last snippet! Should I edit the PR to make this change in the relative docs then?
|
I think it's worth adding a note to the gitlab docs, thanks |
Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.
@samypr100 @zanieb Turned the correction to a note. Please have a look. |
Summary
Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.
Test Plan
Without specifying an entrypoint when using a distroless image:
It works if you either specify the entrypoint or if the image used in not a distroless one.