Add --gui-script flag for running Python scripts with pythonw.exe on … #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajko-rad
force-pushed
the
add-gui-script-flag-6805
branch
from
e6ca059
to
4740ff3
Compare
|
You can add an ignore for that Clippy complaint, if you want — or we will. We generally take our time about splitting those bools out into a struct. |
zanieb
reviewed
Nov 18, 2024
crates/uv/tests/it/run.rs
Outdated
| sys.exit(1) | ||
| "#})?; | ||
|
|
||
| let output = context.run().arg("--script").arg("script").output()?; |
There was a problem hiding this comment.
Should this be using --gui-script?
There was a problem hiding this comment.
Agreed, but would this pass with exit code 0 on a headless windows CI run?
There was a problem hiding this comment.
you are right, and I'm slightly confused why/how we passed tests with that typo... Changing now and will see how it behaves!
|
Nice! I made some minor tweaks and have one blocking question. |
Perfect thank you! |
removed attempt to detect GUI console & just check execution engine instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6805
Summary
This PR adds a
--gui-scriptflag touv runthat allows running Python scripts withpythonw.exeon Windows, regardless of file extension. This solves the issue where users need to maintain duplicate.pyand.pywfiles to run the same script with and without a console window.The implementation follows the pattern established by the existing
--scriptflag, but usespythonw.exeinstead ofpython.exeon Windows. On non-Windows platforms, the flag is present but returns an error indicating it's Windows-only functionality.Changes:
--gui-scriptflag (Windows-only)Test Plan
The changes are tested through:
New Windows-specific test that verifies:
pythonw.exewhen using--gui-scriptNew non-Windows test that verifies:
--gui-scriptis used on non-Windows platformsDocumentation updates to clearly indicate Windows-only functionality