New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat deprecated aliases as equivalent in marker algebra #9342

Open

charliermarsh wants to merge 1 commit into charlie/lower from charlie/lower-i

+49 −52

Member

charliermarsh commented Nov 22, 2024

Summary

This PR modifies our lowered representation such that any deprecated aliases are treated as "the same" marker in the algebra.

So, for example, we now recognize that this is impossible, despite the marker names being different:

typing-extensions ; platform.python_implementation == 'CPython' and python_implementation != 'CPython'

Similarly, we now recognize that this is just sys_platform == 'win32', despite the presence of both markers:

anyio ; sys_platform == 'win32' and sys.platform == 'win32'


          Treat deprecated aliases as equivalent in marker algebra

46f51be

charliermarsh added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug