Remove python_version from lowered marker representation
#9343
+39
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Nov 22, 2024
| MarkerTreeKind::True => true, | ||
| MarkerTreeKind::False => false, | ||
| MarkerTreeKind::Version(marker) => marker.edges().any(|(range, tree)| { | ||
| if marker.key() == LoweredMarkerValueVersion::PythonVersion { |
There was a problem hiding this comment.
An example of why this is important: I think this was just straight-up wrong? (But it's unused.)
charliermarsh
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We never construct these -- they should be impossible, since we always translate to
python_full_version. This PR encodes that impossibility in the types.