Combine sys_platform and platform_system in marker algebra
#9344
+394
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/lower-iii
branch
3 times, most recently
from
2b8d450
to
cfc5550
Compare
charliermarsh
force-pushed
the
charlie/lower-iii
branch
from
cfc5550
to
1c03cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a representation to the marker algebra to capture "known pairs" of
sys_platformandplatform_systemvalues.For example, we want to be able to detect that
sys_platform == 'win32'andplatform_system == 'Darwin'are disjoint.There is some risk here, in that if there are platforms for which, e.g.,
sys_platform == 'win32butplatform_systemis notWindows, we'll get things wrong. I'm trying to weigh whether that's a real risk.In theory, we could maybe also include
os.namehere?Closes #7760.
Closes #9275.