Updated table of contents and markdown cells for GHOST notebook.#259
Merged
Updated table of contents and markdown cells for GHOST notebook.#259
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jacquesalice
requested changes
May 14, 2025
Member
jacquesalice
left a comment
jacquesalice
left a comment
There was a problem hiding this comment.
Hi @bmerino95 . The notebook looks good! Just a few things:
- I was wondering if there was a reason you link to v3.2.1 of the DRAGONS readthedocs page instead of the stable version in your Summary section?
- In the Summary section, change "...when a DRAGON command..." --> "when a DRAGONS command..."
- Also in the Summary section, change "In this notebook, we present an example of a DRAGONS Jupyter notebook..." --> "We present an example of a DRAGONS Jupyter notebook..." or something like that
- Somewhere in the Summary section I think you should mention the maximum amount of storage space the downloaded and altered files will [temporarily] take up. In case someone would be worried about that. From what I see, it's no more than ~3 GB at any point.
- In the bias reduction section, the filenames you say will be created are different from what is actually created:
S20230417S0040_slit_bias.fits .. instead S20230417S0011_slit_bias.fits
S20230417S0012_red001_bias.fits .. instead S20230417S0011_red001_bias.fits
S20230417S0038_red001_bias.fits .. instead S20230417S0036_red001_bias.fits
S20230417S0039_blue001_bias.fits .. instead S20230417S0036_blue001_bias.fits - And in the flats section:
S20230416S0047_red002_flat.fits .. instead S20230416S0047_red001_flat.fits
Contributor
Author
|
Hi @jacquesalice. Thank you for the feedback! I don't know how I missed so many file names being mislabeled. I just went through and made all the changes you suggested. |
jacquesalice
approved these changes
May 15, 2025
Member
jacquesalice
left a comment
jacquesalice
left a comment
There was a problem hiding this comment.
Thanks @bmerino95 ! Approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have shortened the table of contents for the GHOST notebook and updated some markdown cells.