Issue/7 - 修改預設日期及時間以及更新行事曆上資料 #21

AranceLiu · 2023-12-20T02:58:04Z

修改 edit events的時候，date 跟 time 不能有預設：

Screen.Recording.0005-12-20.at.10.48.22.AM.mov

當在行事曆上移動，要更新資料：

Screen.Recording.0005-12-20.at.10.50.32.AM.mov

ryoma510260 · 2023-12-20T10:49:10Z

app/controllers/events_controller.rb

@@ -31,6 +31,10 @@ def show; end

  def edit; end

+  def drop
+    @event.update(event_params)


想問：
1.drop是'拖拉事件'方法?
2.需要加上 @event.save 嗎?

打API把dates傳回來更新
我不覺得使用update需要用.save

update 方法裡已內建 save，所以的確是不用再另外執行

Kkrystalll · 2023-12-21T04:44:26Z

想問這邊當初為何需要分為 date 跟 time 兩個欄位，而不是直接給 datetime?

t.date "start_date", null: false
t.time "start_time"
t.date "end_date", null: false
t.time "end_time"

AranceLiu · 2023-12-21T04:50:07Z

想問這邊當初為何需要分為 date 跟 time 兩個欄位，而不是直接給 datetime?
t.date "start_date", null: false

t.time "start_time"

t.date "end_date", null: false

t.time "end_time"

本來應該是只有兩個欄位（開始、結束）都用datetime
但後來討論可能有時間的話要串Google calendar api，所以分成四個欄位
雖然我也不確定有沒有時間夠不夠到可以串到

Kkrystalll · 2023-12-21T04:45:50Z

app/javascript/controllers/calendar_controller.js

+  const id = e.event.id;
+  const url = `/events/${id}/drop`;
+  const data = { start_date, start_time, end_date, end_time };
+  console.log(data);


console.log()

記得移除

Kkrystalll · 2023-12-21T04:48:03Z

test/models/calendar_test.rb

+  # test "the truth" do
+  #   assert true
+  # end
+end


不用的檔案可刪

Kkrystalll · 2023-12-21T04:57:50Z

app/javascript/controllers/datepicker_controller.js

@@ -19,7 +19,7 @@ export default class extends Controller {
    flatpickr(this.startDateTarget, {
      enableTime: false,
      minDate: "today",
-      defaultDate: "today",
+


如果希望有資料的時候顯示資料內容，沒有資料的時候顯示預設，可以在 _form.html.erb 裡改成

<%= form.date_field :start_date, value: event.start_date || Date.today, class:'form-input', required: true, data:{ datepicker_target:"startDate"} %>

加上 value: event.start_date || Date.today ，其他欄位同理

Kkrystalll · 2023-12-21T05:00:01Z

app/controllers/events_controller.rb

@@ -31,6 +31,10 @@ def show; end

  def edit; end

+  def drop
+    @event.update(event_params)
+  end


這邊優化部分可以另外開票，就是若是今天有更新失敗的時候錯誤處理會是怎樣
例如跳 notice 之類的

#32
我先開一個之後處理

Kkrystalll · 2023-12-21T05:01:23Z

app/views/events/index.html.erb

-    </div>
-</div> 
+
+


這個空兩行跑 rubocop 會錯吧？
可以養成習慣在推上來之前跑一下 rubocop

這邊沒有說有問題
我手動調整了

Kkrystalll · 2023-12-21T05:08:37Z

app/javascript/controllers/calendar_controller.js

+  const start_time = start[1].split(".")[0];
+  const end = new Date(end_at).toISOString().split("T");
+  const end_date = end[0];
+  const end_time = end[1].split(".")[0];


這邊處理時間的話建議可以找 js 處理時間的套件
會方便非常多

感謝建議我再來找找

使用 dayjs：

const start_at = dayjs.utc(e.event.start); const end_at = dayjs.utc(e.event.end); const start_date = start_at.format("YYYY-MM-DD"); const start_time = start_at.format("HH:mm:ss"); const end_date = end_at.format("YYYY-MM-DD"); const end_time = end_at.format("HH:mm:ss");

… current time and date for now

AranceLiu changed the title ~~Issue/7~~ Issue/7 - 修改預設日期及時間以及更新行事曆上資料 Dec 20, 2023

AranceLiu force-pushed the issue/7 branch from 7b39357 to f70d194 Compare December 20, 2023 03:43

ryoma510260 reviewed Dec 20, 2023

View reviewed changes

ryoma510260 previously approved these changes Dec 20, 2023

View reviewed changes

Kkrystalll reviewed Dec 21, 2023

View reviewed changes

TimChaoTW previously approved these changes Dec 22, 2023

View reviewed changes

AranceLiu force-pushed the issue/7 branch from 9a8c342 to c1aca79 Compare December 22, 2023 16:16

AranceLiu requested a review from Liu-Yun-Syuan December 26, 2023 11:51

AranceLiu added 13 commits December 27, 2023 20:53

Event add butoon for modal

ef64ddc

WIP: Calendar-CRUD

c8f6a07

Event: fix pick date

03ef154

Event: fix when edit date should show the record which in DB

02e53d4

Event: adjst from calendar

da99c99

Event: replace on calendar and update

67156d7

Delete file which didn't use

7db1b9d

Delete console.log which just test for the data which I saw

5a56118

Using _value_ in form: show event data when exist data, otherwise use…

77a301e

… current time and date for now

Use rubocop

bc25748

Delete by manually since it's doesn't detected from rubocop

0ccde48

add dayjs and extend utc

64b8415

Event: API - fix date for using packages

cbedad5

AranceLiu force-pushed the issue/7 branch from 976794c to cbedad5 Compare December 27, 2023 13:00

AranceLiu dismissed stale reviews from TimChaoTW and ryoma510260 via cbedad5 December 27, 2023 13:11

Deleted a before action which I deleted before

bfd46cb

ryoma510260 approved these changes Dec 27, 2023

View reviewed changes

Liu-Yun-Syuan approved these changes Dec 27, 2023

View reviewed changes

TimChaoTW approved these changes Dec 28, 2023

View reviewed changes

TimChaoTW merged commit 37885da into dev Dec 28, 2023

TimChaoTW deleted the issue/7 branch December 28, 2023 14:47

AranceLiu self-assigned this Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue/7 - 修改預設日期及時間以及更新行事曆上資料 #21

Issue/7 - 修改預設日期及時間以及更新行事曆上資料 #21

AranceLiu commented Dec 20, 2023

ryoma510260 Dec 20, 2023

AranceLiu Dec 21, 2023

kaochenlong Dec 21, 2023

Kkrystalll commented Dec 21, 2023

AranceLiu commented Dec 21, 2023

Kkrystalll Dec 21, 2023

Kkrystalll Dec 21, 2023

Kkrystalll Dec 21, 2023

Kkrystalll Dec 21, 2023

AranceLiu Dec 22, 2023

Kkrystalll Dec 21, 2023

AranceLiu Dec 22, 2023

Kkrystalll Dec 21, 2023

AranceLiu Dec 22, 2023

AranceLiu Dec 22, 2023 •

edited

Loading

Issue/7 - 修改預設日期及時間 以及 更新行事曆上資料 #21

Issue/7 - 修改預設日期及時間 以及 更新行事曆上資料 #21

Conversation

AranceLiu commented Dec 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kkrystalll commented Dec 21, 2023

AranceLiu commented Dec 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AranceLiu Dec 22, 2023 • edited Loading

Choose a reason for hiding this comment

Issue/7 - 修改預設日期及時間以及更新行事曆上資料 #21

Issue/7 - 修改預設日期及時間以及更新行事曆上資料 #21

AranceLiu Dec 22, 2023 •

edited

Loading