Skip to content

Conversation

@jvinet
Copy link

@jvinet jvinet commented Nov 6, 2018

I've added a new --smooth option, which will collect X samples (one per --interval) before logging/plotting; this will reduce the spikey-ness of the graph.

Here's an example of the difference using --interval 0.1 and --smooth 50 (= one graph/log point every 5 seconds).

ps-smoothing

And here's the same process without --smooth

ps-original

…) before logging/plotting; this will reduce the spikey-ness of the graph
@jgehrcke
Copy link

The approach taken in this PR rolls the time window in window width increments (instead of in increments corresponding to the original time difference between samples), which adds a non-natural frequency component to the output, and after all doesn't smooth as "effectively" as it could.

I think smoothing should be done using a "proper" rolling time window analysis. That's what I have made good experiences with over the years. I've implemented this approach in https://github.com/jgehrcke/goeffel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants