New module to query Lowell Observatory astorbDB database #3203
Conversation
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
…b.com/hhsieh00/astroquery into 3129-add-lowell-astorbdb-query-module
fixing more codestyle issues in core.py
|
|
||
| timeout = _config.ConfigItem( | ||
| 30, | ||
| 'Time limit for connecting to template_module server.') |
| _uri = None | ||
|
|
||
| def designations_async(self, object_name, *, | ||
| get_raw_response=False, |
There was a problem hiding this comment.
get_raw_response keyword argument should not be used (the async method always returns a raw response)
There was a problem hiding this comment.
Similarly, remove the related if statement, and edit the other methods.
|
|
||
| def designations_async(self, object_name, *, | ||
| get_raw_response=False, | ||
| get_uri=False, |
There was a problem hiding this comment.
I don't think this is needed either. Maybe you were following the jplhorizons module? (which is ancient frankencode)
There was a problem hiding this comment.
Similarly, remove the related if statement, and edit the other methods.
|
|
||
| return response | ||
|
|
||
| def dynamicalfamily_async(self, object_name, *, |
There was a problem hiding this comment.
My personal preference is dynamical_family_async.
|
|
||
| return response | ||
|
|
||
| def escaperoutes_async(self, object_name, *, |
There was a problem hiding this comment.
similarly: escape_routes_async
| """ | ||
|
|
||
| if 'elements' in src: | ||
| src = OrderedDict(src['elements']) |
There was a problem hiding this comment.
Is there a reason for OrderedDict?
| except ValueError: | ||
| raise ValueError('Server response not readable.') | ||
|
|
||
| if self.query_type == 'designations': |
There was a problem hiding this comment.
if ... elif ... elif would be better: indicates that only one match can occur, and allows for a final else that can raise a ValueError in case of no match.
|
Thanks @mkelley for the review. I haven't looked into it in any meaningful way yet, but I notice that there are a lot of comments on async stuff. We should remove/rework the template module as a lot has changed. E.g. there is a preference of supporting actual async/sync API and not just with the early template hackary. So I would suggest to so that, too, if the service support async, then opt into that with a keyword argument, but don't duplicate the methods with the decorator. or one PR that did the keyword approach: #3201 or the ESA modules also have a |
This is a new module for querying the Lowell Observatory astorbDB database (see issue #3129), specifically using REST APIs used to run their AstInfo tool (https://asteroid.lowell.edu/astinfo/). The AstInfo class in this module specifically retrieves designation, orbital element, orbit, albedo, color, taxonomy, lightcurve, dynamical family, and escape route data for asteroids catalogued in the Lowell astorbDB database.