Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: returning (Q)Table for Alma.query_sia #3261

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Mar 17, 2025

This has been pulled out from #3252. Also, based on the discussion, I added the enhanced_results kwarg, but again, this is an API change for whomever is using query_sia as they don't get a SIA2Results but a Table/QTable instead.

@bsipocz bsipocz added the alma label Mar 17, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.09%. Comparing base (7494746) to head (02fda13).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/alma/core.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3261   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files         232      232           
  Lines       19637    19642    +5     
=======================================
+ Hits        13568    13572    +4     
- Misses       6069     6070    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant