Skip to content

MAINT: update urls and response parsing for imcce #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 8, 2025

This is to address the issue #3282

The skybot part is trivial, however the response have changed for miriade and there are a multitude of issues:

  1. tcoor=6 is removed, but this seems to be consistent with the documentation
  2. target name is not returned for mime type votable, even though the docs only mentions it for text. Is that right?
  3. lots of columns are renamed from how they were called before. This seems to be easy to fix for tcoor=1 case, but all the rest seems to be a bit of a mess as the returned result seems to be inconsistent both with previous behaviour and online docs. I've included the update data files in this PR, so those can be used to double check if all goes well.

Overall a lot of manual massaging and parsing is needed as some of the fields are not parsed properly by the votable parser in astropy. I've opened some new issues and commented on old ones, but I would not hold my breath and we need a workaround here sooner than any of this would be fixed upstream.

cc @darkmoloko for the issues above, and also to double check the code. However I haven't fixed all of 3) as the outputs just don't look right, so first I would need a confirmation that they are legit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant