Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adopt the array api #885

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented Mar 19, 2025

This PR makes the necessary changes to adopt the array API. There are still some things to sort out:

  • Run tests mostly against numpy, but do one run against jax (or some other non-numpy array library)
  • Check for remaining invocations of numpy in the code.
  • Check whether changing .data_arr.mask to .data_arr_mask constitutes an API change. If it does (and I think it does) then patch things up so that .data_arr.mask points to .data_arr_mask

Once those are done the next step will be to find an outside reviewer for this...

@mwcraig mwcraig added this to the 2.5.0 milestone Mar 19, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 93.65079% with 12 lines in your changes missing coverage. Please review.

Project coverage is 97.08%. Comparing base (211d9ef) to head (ff7f319).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ccdproc/combiner.py 92.92% 7 Missing ⚠️
ccdproc/core.py 94.18% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   97.87%   97.08%   -0.79%     
==========================================
  Files           8        8              
  Lines        1362     1443      +81     
==========================================
+ Hits         1333     1401      +68     
- Misses         29       42      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant