Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are based on the automatic
clippy --fix
changes, with some many changes to reduce the noise.max_value()
toMAX
and the cfg change are manual.After this PR there are two more clippy warnings, which I didnt apply because I am worried it may slightly change the API, thus introduce backwards incompatibility.
Note I dont see any substantive overlap with #948 , so I guess that the clippy warnings from 2021 have all since been addressed and that PR can be closed.