Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support cli to fetch private templates #1399

Merged
merged 16 commits into from
May 13, 2024
Merged

chore: support cli to fetch private templates #1399

merged 16 commits into from
May 13, 2024

Conversation

AayushSaini101
Copy link
Contributor

Resolves: #1081

@AayushSaini101 AayushSaini101 marked this pull request as draft May 1, 2024 05:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AayushSaini101 AayushSaini101 changed the title feat:support cli to fetch private templates feat: support cli to fetch private templates May 1, 2024
@AayushSaini101 AayushSaini101 marked this pull request as ready for review May 1, 2024 06:09
Shurtu-gal
Shurtu-gal requested changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AayushSaini101 !!
Left a few comments.

Also could we follow the flags naming format till now and rename the flags to registry-url, registry-auth and registry-token

src/commands/generate/fromTemplate.ts Outdated Show resolved Hide resolved
src/commands/generate/fromTemplate.ts Outdated Show resolved Hide resolved
src/commands/generate/fromTemplate.ts Outdated Show resolved Hide resolved
@Shurtu-gal Shurtu-gal changed the title feat: support cli to fetch private templates chore: support cli to fetch private templates May 2, 2024
Amzani
Amzani requested changes May 6, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Amzani Amzani mentioned this pull request May 13, 2024
Closed
Amzani
Amzani approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
created #1421

@AayushSaini101
Copy link
Contributor Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @AayushSaini101! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: To request an update from the upstream branch, simply comment /u or /update and our bot will handle the update operation promptly.

       The only requirement for this to work is to enable [Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) option in your PR. Also the update will not work if your fork is located in an organization, not under your personal profile.
       Thanks 😄

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 5c99587 into asyncapi:master May 13, 2024
12 checks passed
@Amzani Amzani mentioned this pull request May 14, 2024
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Amzani Amzani mentioned this pull request May 15, 2024
Closed
2 tasks
@AayushSaini101 AayushSaini101 mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shurtu-gal Shurtu-gal Shurtu-gal approved these changes

@Souvikns Souvikns Souvikns approved these changes

@Amzani Amzani Amzani approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable new feature from Generator to support templates hosted as private packages
5 participants
@AayushSaini101 @asyncapi-bot @Shurtu-gal @Amzani @Souvikns