-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement 'new glee' command #418
feat: implement 'new glee' command #418
Conversation
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going great! 💪
I left a few suggestions. Also, if I recall correctly, the asyncapi new glee
command should have an alias called asyncapi new project
. You should add that by creating the project.ts
file in the same directory. It can simply be a file that imports the glee.ts
and exports everything it's exporting (same as with new/index.ts
, which is an alias of new/file.ts
). Also, make sure console messages suggest asyncapi new project
or asyncapi new glee
, depending on which one has been used.
Keep up the great work 🙌
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments but it's already looking good to get out of the Draft PR stage 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have conflicts in the package-lock.json file. My suggestion is that you fix it by doing git pull
(you'll get the conflicts in your machine), remove package-lock.json
and node_modules
, and then run npm install
. After that, just continue the usual git commit
workflow.
just my suggestion is that better do not remove |
getting this error in tests
I see that the MaxListeners were increased, Line 14 in 6e1484b
I am unable to understand why this has to be increased and does this affect this error. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/rtm |
🎉 This PR is included in version 0.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Related issue(s)
Resolves #184