-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce monorepo to Generator Repo #1186
Conversation
docs: clarify paho version & fix typo (#1146)
@asyncapi/bounty_team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff needs update because of docs related links and automation:
- doc hooks.md need update of links pointing to GH that would break, change them to relative link from website, which will be
/docs/tools/generator/api
- workflow update-docs-in-website needs an update of link that now point to
/generator/docs/
, and probably should point to/generator/apps/generator/docs/
additionally:
|
|
@AyushNautiyalDeveloper no, it just should be links in docs do not have to work in github in markdown, they need to work in website, where people read them |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
why we have
apps/generator/.gitignore
instead of having one gitignore in root? -
I believe
apps/generator/assets/readme-banner.png
must stay in the root -
apps/generator/.releaserc
should also stay in root, right? it is a release config file and should be same for all, no? -
please add some
Development
guide to readme, that explains what I need to do locally to start the project, run tests -
please also explain how pushing to npm will work now. This is current release workflow https://github.com/asyncapi/generator/blob/master/.github/workflows/if-nodejs-release.yml where for example you can see we need
npm test
available in the root, that will trigger all tests of all projects -
also, the plan was filters are not in the PR but another one, so we should not have all these filters scripts in package.json
-
did you run all tests on local? are you sure we do not need to make any amendments in
test/test-project/test.sh
?
package.json
Outdated
"access": "public" | ||
"devDependencies": { | ||
"prettier": "^3.2.5", | ||
"turbo": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we really point to latest? isn't it risky and error prone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made it to the current latest version.
package.json
Outdated
"dev": "turbo dev", | ||
"test": "turbo run test", | ||
"lint": "turbo lint", | ||
"format": "prettier --write \"**/*.{ts,tsx,md}\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what we need it for? we do not use ts here anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Also i found that the test are not running properly with the current version. the issue is still not fixed |
@ayushnau how is it going, do you need anything? |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pr is moved to #1213 |
Changes Added.
Related issue(s)
Resolves #1044