fix: change the version from '*' to their original versions #1344
Conversation
ItshMoh
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 029a7c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
ItshMoh
changed the title
|
@derberg can you run the workflow? |
|
tests are failing |
|
please add changeset according to https://github.com/asyncapi/generator/blob/master/Development.md#release-process |
|
Hey @derberg in the markdown file for .changeset do i have to include the patch release of those packages also who are not published on the npm registry? |
|
hey @derberg can you review the version.md in .changeset? |
.changeset/version.md
Outdated
| "@asyncapi/generator-hooks": patch | ||
| "@asyncapi/nunjucks-filters": patch | ||
| "@asyncapi/generator-components": patch | ||
| "@asyncapi/generator-helpers": patch |
There was a problem hiding this comment.
we should release generator only and here you patch all the other packages which we do not want to include in npm
remember currently it is monorepo still publishing one package
maybe @asyncapi/generator-components, @asyncapi/generator-helpers in future will also be released separately, but for now they are highly experimental
There was a problem hiding this comment.
@derberg updated the version.md.
derberg
changed the title
| - Changed the version of `@asyncapi/generator-hooks`, `@asyncapi/generator-components`, `@asyncapi/generator-helpers` and `@asyncapi/nunjucks-filters` from '*' to their original version. | ||
|
|
||
| - Replaced asterisk (*) version specifier with explicit version numbers in package dependencies. While the wildcard was intended to resolve packages from local workspaces, it resulted in unnecessary npm registry lookups for unpublished packages. This change ensures proper local workspace resolution and prevents failed registry lookups, improving both reliability and performance. | ||
|
|
There was a problem hiding this comment.
I really don't get the emoji @derberg. Is it because in the markdown I copypasted the PR description. If yes then this emoji suits this case iykyk
Co-authored-by: Lukasz Gornicki <[email protected]>
|
|
@derberg can you run the workflow? |
|
@ItshMoh done |
|
@derberg there is still the time out issue .The error is installation failed. |
|
@ItshMoh please increase timeouts - we really can't do much here, this damn issues were happening on windows in the past, then we increased timeout, and looks like GH is messing with windows images again |
Changed the version of @asyncapi/generator-hooks, @asyncapi/generator-components, @asyncapi/generator-helpers from '*' to their original version.
Description
Replaced wildcard (*) version specifier with explicit version numbers in package dependencies. While the wildcard was intended to resolve packages from local workspaces, it resulted in unnecessary npm registry lookups for unpublished packages. This change ensures proper local workspace resolution and prevents failed registry lookups, improving both reliability and performance.
Related issue(s)