Skip to content

fix: correctly detect default values including false in template parameters #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lightning-sagar wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix: correctly detect default values including false in template parameters #1769

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3a2d80f
fix: correctly detect default values including false in template para…
lightning-sagar Nov 25, 2025
deff989
ci: update release pipeline (#1774)
derberg Dec 1, 2025
a04a2b4
feat: release `@asyncapi/keeper` and use for message validation in `J…
Adi-204 Dec 1, 2025
ce7ceda
fix: add generator onboarding webinar to contributing guides (#1753)
Kartikayy007 Dec 2, 2025
1131dca
chore(release): release and bump versions of packages (#1775)
asyncapi-bot Dec 2, 2025
c0744b6
feat: update release worflow and trigger release (#1776)
derberg Dec 3, 2025
e1a13c8
chore(release): release and bump versions of packages (#1777)
asyncapi-bot Dec 3, 2025
43f50f3
fix: add proper token requirements to release (#1778)
derberg Dec 3, 2025
1a70eb9
chore(release): release and bump versions of packages (#1779)
asyncapi-bot Dec 3, 2025
9be72ce
fix: make sure to use latest npm for release pipeline (#1780)
derberg Dec 3, 2025
091ec69
fix: add to release option to read NODE_VERSION variable (#1781)
derberg Dec 4, 2025
2141594
chore(release): release and bump versions of packages (#1782)
asyncapi-bot Dec 4, 2025
f96cf7e
ci: update of files from global .github repo (#1783)
asyncapi-bot Dec 4, 2025
4046fa5
fix(template-params): correctly detect default values including false…
lightning-sagar Dec 6, 2025
802b021
Merge branch 'master' into fix/template-params
lightning-sagar Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/generator/lib/templates/config/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async function loadTemplateConfig(templateDir, templateParams) {
*/
function loadDefaultValues(templateConfig, templateParams) {
const parameters = templateConfig.parameters;
const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default);
const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default !== undefined);

defaultValues.filter(dv => !Object.prototype.hasOwnProperty.call(templateParams, dv)).forEach(dv =>
Object.defineProperty(templateParams, dv, {
Expand Down