Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for using AsyncAPI CLI #433

Merged
merged 10 commits into from
Jul 15, 2023

Conversation

Arya-Gupta
Copy link
Contributor

Description
Previously the README contained instructions on how to use the template using Generator. I have added instructions on an alternate way of using the template using the AsyncAPI CLI.

Tagging @derberg

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Arya-Gupta Arya-Gupta changed the title docs: Added instructions for using AsyncAPI CLI docs: added instructions for using AsyncAPI CLI Jul 10, 2023
@derberg derberg changed the title docs: added instructions for using AsyncAPI CLI docs: add instructions for using AsyncAPI CLI Jul 10, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR 🙏🏼
left some suggestions

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Arya-Gupta Arya-Gupta requested a review from derberg July 10, 2023 19:31
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, how about development section?

README.md Outdated Show resolved Hide resolved
Arya-Gupta and others added 2 commits July 12, 2023 19:39
Signed-off-by: Arya Gupta <[email protected]>

Co-authored-by: Lukasz Gornicki <[email protected]>
@Arya-Gupta Arya-Gupta requested a review from derberg July 13, 2023 02:10
@Arya-Gupta Arya-Gupta marked this pull request as ready for review July 13, 2023 12:45
README.md Outdated Show resolved Hide resolved
@Arya-Gupta Arya-Gupta requested a review from derberg July 13, 2023 18:27
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry but have to ask for another change, my bad

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Arya-Gupta and others added 2 commits July 14, 2023 01:18
Signed-off-by: Arya Gupta <[email protected]>

Co-authored-by: Lukasz Gornicki <[email protected]>
Signed-off-by: Arya Gupta <[email protected]>

Co-authored-by: Lukasz Gornicki <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Arya-Gupta Arya-Gupta requested a review from derberg July 13, 2023 19:49
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks 🙏

@derberg
Copy link
Member

derberg commented Jul 15, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 2130f97 into asyncapi:master Jul 15, 2023
@derberg
Copy link
Member

derberg commented Jul 17, 2023

@allcontributors please add @Arya-Gupta for docs

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @Arya-Gupta! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.28.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants