Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check @Pattern wth backslashes #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glandais-mdm
Copy link

Description

The @pattern doesn't contain expected regexp.

Related issue(s)
Reproduces #374

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@glandais-mdm glandais-mdm changed the title test: Check @Pattern wth backslashes test: check @Pattern wth backslashes Feb 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 5, 2024
@Tenischev
Copy link
Member

Hi @glandais-mdm
Thank you for the PR.
I'm a bit frustrated with the description "The @pattern doesn't contain expected regexp."
As I may see the PR you only enhance test, without changes to the template.
Is it what you would like to do? Might be in this case with could name PR "adding pattern test"?

@Tenischev Tenischev removed the stale label Jun 24, 2024
@glandais-mdm
Copy link
Author

From what I remember, the test was failing for this MR.
We changed our mind on how to generate code from our asyncapi contracts, I will not be able to help about that :(

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants