fix: changes made to the objectSchema #380
Conversation
rakeshkodathala
requested review from
Tenischev,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
rakeshkodathala
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
Hi @rakeshkodathala |
| {%- if prop.minimum() %}@Min({{prop.minimum()}}){% endif %}{% if prop.exclusiveMinimum() %}@DecimalMin({{prop.exclusiveMinimum() + 1}}){% endif %} | ||
| {%- if prop.maximum() %}@Max({{prop.maximum()}}){% endif %}{% if prop.exclusiveMaximum() %}@DecimalMax({{prop.exclusiveMaximum() + 1}}){% endif %} |
There was a problem hiding this comment.
The prop.minimum() means <=, the prop.maximum() means >= and exclusiveMinimum means just < and exclusiveMaximum is >.
So, change of exclusiveMinimum and exclusiveMaximum to @DecimalMin/@DecimalMax will lead to effect that all types (Integer, Long, Double e.t.c.) will have the @DecimalMin annotation.
The correct way to choose annotation between @Min and @DecimalMin, @Max and @DecimalMax would require to analyze value of {{propType}} in line below. Depending on {{propType}} the correct annotation should be set
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Resolves #326
As said by @Tenischev, changes have been made to the file by modifying Min and Max to DecimaMin and DecimaMax