Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update meetings.json and newsrooom_videos.json #3425

Merged
merged 1 commit into from
Nov 23, 2024
Merged

chore: update meetings.json and newsrooom_videos.json #3425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/meetings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,5 +131,12 @@
"url": "https://github.com/asyncapi/community/issues/1592",
"banner": "",
"date": "2024-11-21T12:00:00.000Z"
},
{
"title": "Community Meeting",
"calLink": "https://www.google.com/calendar/event?eid=NmQzNTJzbW91NTNscGo4dnJoMWNlM3J2YnMgY19xOXRzZWlnbG9tZHNqNm5qdWh2YnB0czExY0Bn",
"url": "https://github.com/asyncapi/community/issues/1596",
"banner": "https://github.com/user-attachments/assets/ff469484-a2c5-4aa2-8652-782f017947fb",
"date": "2024-11-26T16:00:00.000Z"
Comment on lines +134 to +140
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Entries in meetings.json are not in chronological order

The new Community Meeting entry is valid and consistent, but the file's entries are not properly sorted by date. The sort command detected that 2024-09-03T08:00:00.000Z is out of order, indicating that meetings are not chronologically arranged.

  • Consider sorting the meetings array by date to maintain consistent chronological order
🔗 Analysis chain

LGTM! The new meeting entry follows the established structure.

The new Community Meeting entry maintains consistency with:

  • All required fields present
  • Proper JSON syntax
  • ISO 8601 date format
  • Valid GitHub issue reference pattern

Let's verify the GitHub issue reference and calendar link:

Verified: GitHub issue and meeting details are consistent

The GitHub issue exists and contains matching information:

  • Issue fix: update @asyncapi/modelina to 1.4.0 version #1596 is open and titled "Community Meeting, 16:00 UTC Tuesday November 26th 2024"
  • The meeting time in the issue (16:00 UTC) matches the ISO date in meetings.json
  • The banner URL in meetings.json matches the one in the issue body
  • The issue was created by asyncapi-bot and is properly labeled as "meeting"

Let's verify the chronological order of entries:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the GitHub issue exists and is accessible
# Expected: Status code 200 for valid issue

gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  repos/asyncapi/community/issues/1596

Length of output: 4631

Script:

#!/bin/bash
# Check if entries are sorted by date
cat config/meetings.json | jq -r '.[] | .date' | sort -c

Length of output: 104

}
]
Loading