Skip to content

fix(ui): Correct banner alignment on non-home pages (closes #4495) #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raajpatre wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −280
Open

fix(ui): Correct banner alignment on non-home pages (closes #4495) #4552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f395412
changes
raajpatre Nov 6, 2025
825f54f
fix(ui): Correct banner alignment on non-home pages (closes #4495)
raajpatre Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/campaigns/AnnouncementBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ export default function Banner({
}: BannerProps) {
return (
<div
className={`size-full rounded border border-gray-200 bg-gray-50 py-6
transition-transform${className} ${small ? 'mb-4' : 'mx-3 my-6 p-3'}
className={`size-full rounded border border-gray-200 bg-gray-50
p-6 mx-3 ${small ? 'mb-4' : 'my-6'}
transition-transform ${className}
${activeBanner ? 'z-10 scale-100 opacity-100' : 'z-0 scale-90 opacity-0'}`}
data-testid='AnnouncementHero-main-div'
>
Expand Down
2 changes: 1 addition & 1 deletion config/tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"title": "AsyncAPI Server API",
"description": "Server API providing official AsyncAPI tools",
"links": {
"websiteUrl": "https://api.asyncapi.com/v1",
"websiteUrl": "https://api.asyncapi.com/v1",
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove trailing whitespace.

There's a trailing space after the URL that appears unrelated to the banner fix. This should be removed to maintain clean formatting.

Apply this diff:

-          "websiteUrl": "https://api.asyncapi.com/v1", 
+          "websiteUrl": "https://api.asyncapi.com/v1",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"websiteUrl": "https://api.asyncapi.com/v1",
"websiteUrl": "https://api.asyncapi.com/v1",
🤖 Prompt for AI Agents 
In config/tools.json around line 26, the "websiteUrl" entry contains a trailing
space after the URL; remove the extra space so the line ends with
"https://api.asyncapi.com/v1" (no trailing whitespace) and save the file to keep
formatting clean.

"docsUrl": "https://api.asyncapi.com/v1/docs",
"repoUrl": "https://github.com/asyncapi/server-api"
},
Expand Down
278 changes: 1 addition & 277 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading