-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: clean react error in the console #4642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
WalkthroughTwo components receive refactoring updates: Hero.tsx modifies orbit map keys to use composite identifiers combining orbit ID and index for uniqueness, while Dashboard.tsx corrects SVG attribute naming from kebab-case to camelCase to align with React JSX conventions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 799 799
Branches 146 146
=========================================
Hits 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4642--asyncapi-website.netlify.app/ |
|
@tim48-robot Please create an issue first. If you think something needs to be done, the flow should be to first create an issue, maybe have a discussion there if needed, and once the issue is approved, you can then create a PR for it. |
|
Thank you for the response @princerajpoot20 ! Written in CONTRIBUTING.MD: May i know what kind of code change or scope is a really obvious error? ( So later i won't make the same mistake by not creating an issue first ) |
|
@tim48-robot There is no such thing as a |
|
@princerajpoot20 okayy sir thankyou for the answer, i will close the pr right away |
|
@tim48-robot Now that you’ve already raised the PR, please don’t close it. Thanks for your contribution! |
Description
Identified a React warning/error appearing in the browser console regarding
Fixed by updating keys in the Hero component to include the array index for uniqueness. Also cleaned the strokeWidth etc.
Verified that the console is now clean and the error no longer persists when running the application.
Screencast_20251125_002218.webm
@princerajpoot20
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.