Skip to content

Conversation

@sambhavgupta0705
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 commented Dec 1, 2025

fix for failing PR

Summary by CodeRabbit

  • Chores
    • Updated testing infrastructure configuration to use a different macOS runner image in the CI/CD pipeline. No user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

Updates the Node.js PR testing workflow to use the macOS 15 runner image instead of macOS-latest in the matrix configuration, specifying a fixed macOS environment version for consistent test execution on pull requests.

Changes

Cohort / File(s) Change Summary
Workflow Configuration
\.github/workflows/if-nodejs-pr-testing\.yml
Updated macOS runner image in matrix.os from macos-latest to macos-15 for pinned environment consistency

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • derberg
  • akshatnema
  • devilkiller-ag
  • vishvamsinh28
  • anshgoyalevil

Poem

🐰 From macos-latest to macos-15 we go,
A version pinned down, steady and slow,
No floating targets in CI's great scheme,
Just reliable tests in the workflow stream,
Predictable runs—a rabbit's dream! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'ci: fix macos version' directly matches the main change, which updates the macOS runner image in the CI workflow from macos-latest to macos-15.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f78f5f
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/692d20a5bb873800085c873a
😎 Deploy Preview https://deploy-preview-4655--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3fc64a4) to head (0f78f5f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4655   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          799       799           
  Branches       146       146           
=========================================
  Hits           799       799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 1, 2025

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-4655--asyncapi-website.netlify.app/

@derberg derberg changed the title fix: fix macos version ci: fix macos version Dec 1, 2025
@princerajpoot20
Copy link
Member

@sambhavgupta0705 Have you checked the reason why the pipeline is failing on the latest version

@princerajpoot20
Copy link
Member

princerajpoot20 commented Dec 2, 2025

@sambhavgupta0705
I doubt that it’s a macOS version compatibility issue.
The reason I’m saying this is that I saw two recent runs (1st, 2nd), and both are failing. The difference is that one is failing on macOS and the other on Windows. In both runs, the same test case is failing.

Maybe we need to dig deeper to find the actual cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants