Skip to content

Persistence.cs use callback with index#2137

Closed
codrutmarin wants to merge 1 commit intoasynkron:devfrom
codrutmarin:persistence-provider-should-use-callback-with-index
Closed

Persistence.cs use callback with index#2137
codrutmarin wants to merge 1 commit intoasynkron:devfrom
codrutmarin:persistence-provider-should-use-callback-with-index

Conversation

@codrutmarin
Copy link
Copy Markdown

At times certain persistence options don't allow you to delete an event and a common way to deal with this is to read the stream in memory, delete the stream, remove the desired event, and persist the stream. Some storages such as SQL or EventStoreDB will continue the index count from where it left resulting quite often in version conflicts. Rewriting this to use an Index in the callback can fix this bug/issue/inconvenience

Description

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@codrutmarin codrutmarin force-pushed the persistence-provider-should-use-callback-with-index branch from 34dcb51 to 8058d48 Compare October 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants