Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter old events in admin #67

Open
wants to merge 1 commit into
base: otax/production
Choose a base branch
from

Conversation

KasperNurminen
Copy link
Member

Now all events in the history of ilmomasiina are displayed. Should probably remove events over 1 month old, for example

@Jonesus
Copy link
Contributor

Jonesus commented Sep 11, 2019

At some point I feel it might be beneficial to be able to view all old events in the admin UI, maybe with pagination or something

@KasperNurminen
Copy link
Member Author

Don't know how well sequelize/feathers support pagination, what's the use case for viewing very old events? I am just not sure if it is really worth the development effort

@Jonesus
Copy link
Contributor

Jonesus commented Sep 11, 2019

I was mostly considering it from the viewpoint of feature parity with the super legacy php ilmomasiina, I think the full event history from ilmomasiina has been used a couple of times for guild magazine articles, guild history book and IE event statistics, it is true that it's not a high priority feature by any means

@peksi
Copy link
Collaborator

peksi commented Sep 11, 2019

We need to solve #68 before pagination functions correctly.

Feathers uses $limit=n and $skip=n for paginating items in api listing

@peksi
Copy link
Collaborator

peksi commented Oct 9, 2019

I wouldn't put this into production before we have the pagination working

leevironty referenced this pull request in fyysikkokilta/ilmomasiina Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants