add Xena functionality #153
Conversation
|
Revised commit; adds Xena throughput test functionality. |
grdumas
changed the title
if _DEBUG = True, XenaVerify.py will print out additional info about the parameters and values it receives and the command output to Mono
Parameter sets the maximum transmission rate of a Valkyrie2544 test
|
@ctrautma I think we can restart work on this. Obviously the first step we need to do is fix the merge conflicts. |
|
OK I will take a look.
…----- Original Message -----
From: "Karl Rister" <[email protected]>
To: "atheurer/trafficgen" <[email protected]>
Cc: "Christian Trautman" <[email protected]>, "Mention" <[email protected]>
Sent: Tuesday, September 1, 2020 4:01:30 PM
Subject: Re: [atheurer/trafficgen] add Xena functionality (#153)
@ctrautma I think we can restart work on this. Obviously the first step we need to do is fix the merge conflicts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or unsubscribe .
|
| 3. Obtain .x2544 config file & executable | ||
| * Create a test config inside xena2544 utility on the xenaweb system (ask @ctrautma for IP if necessary) | ||
| * Save config into the ftp folder off the c drive | ||
| * Use FTP commands to download the config and the latest copy of Valkyrie2544.exe | ||
| * Place both config and exe inside the trafficgen folder | ||
| ``` | ||
| ftp 11.11.111.11 [user]/[pwd] | ||
| bin | ||
| get valkyrie2544.exe | ||
| get <your config file> |
There was a problem hiding this comment.
Is there anything more generic we could say her that would be useful to other people who might try to use this?
| 5. Install TRex | ||
| * Within trafficgen, open `install-trex.sh` for editing | ||
| * Make the following change: | ||
| * original: `if curl --output ${tarfile} ${trex_url} && tar zxf ${tarfile}; then` | ||
| * modified: ``if curl --insecure --output ${tarfile} ${trex_url} && tar zxf ${tarfile}; then`` | ||
| * As root or using `sudo`, run: `./install-trex.sh` | ||
| * After install completes, replace the following files with copies from test ZIP `fix_trex_install` (or make changes listed in Known Issues): | ||
| * `trex_client.py` --> `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/trex_client.py` | ||
| * `trex_conn.py` --> `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/trex_conn.py` | ||
| * `trex_global_stats.py` --> `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/stats/trex_global_stats.py` |
There was a problem hiding this comment.
Why is TRex stuff included here?
Also, lines 41-43 have been addressed directly in install-trex.sh.
Also a bit confused as to the relevance/reason why lines 45-48 exist?
There was a problem hiding this comment.
The TRex inclusions are because of the following line from the beginning of binary-search.py:
from trex_tg_lib import *
Importing everything from trex_tg_lib in turn kicks off a chain of other imports - end result is that without TRex installed on a system, binary search crashes. For the sake of clarity I'll address the other questions in their own respective comments.
There was a problem hiding this comment.
Ok, that makes sense. I'll have to think if there is a way to work around this. Having to install TRex when you aren't using it just seems so broken...
There was a problem hiding this comment.
I put together a patch that I think will solve these TRex dependency issues:
Can you have somebody test if this patch allows the Valkrie2544 stuff (this PR) to work without having the TRex stuff present as is described in the proposed README files?
| ## Known Issues | ||
| * SyntaxError from `trex_client.py` | ||
| * Open `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/trex_client.py` | ||
| * Change line 1188 from: `self.conn.async.set_timeout_sec(timeout_sec)` to: `self.conn.async_.set_timeout_sec(timeout_sec)` | ||
|
|
||
| * SyntaxError from `trex_conn.py` | ||
| * Open `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/trex_conn.py` | ||
| * Change line 36 from: `self.async = TRexSubscriber(self.ctx, self.rpc)` to: `self.async_ = TRexSubscriber(self.ctx, self.rpc)` | ||
| * Change line 60 from: `self.async.disconnect()` to: `self.async_.disconnect()` | ||
| * Change line 89 from: `self.async.barrier()` to: `self.async_.barrier()` | ||
| * Change line 98 from: `return self.async.barrier(baseline = True)` to: `return self.async_.barrier(baseline = True)` | ||
| * Change line 110 from: `self.async.set_as_zombie()` to: `self.async_.set_as_zombie()` | ||
| * Change line 143 from: `return ( self.async.last_data_recv_ts is not None and ((time.time() - self.async.last_data_recv_ts) <= 3) )` to `return ( self.async_.last_data_recv_ts is not None and ((time.time() - self.async_.last_data_recv_ts) <= 3) )` | ||
| * Change line 189 from: `rc = self.async.connect()` to `rc = self.async_.connect()` | ||
|
|
||
| * SyntaxError from `trex_global_stats.py` | ||
| * Open `/opt/trex/current/automation/trex_control_plane/interactive/trex/common/stats/trex_global_stats.py` | ||
| * Change line 81 from: `("async_util.", "{0}% / {1}".format( format_threshold(round_float(self.client.conn.async.monitor.get_cpu_util()), [85, 100], [0, 85]),` to: `("async_util.", "{0}% / {1}".format( format_threshold(round_float(self.client.conn.async_.monitor.get_cpu_util()), [85, 100], [0, 85]),` | ||
| * Change line 82 from: `format_num(self.client.conn.async.monitor.get_bps() / 8.0, suffix = "B/sec"))),` to: `format_num(self.client.conn.async_.monitor.get_bps() / 8.0, suffix = "B/sec"))),` |
There was a problem hiding this comment.
Again, what relevance does TRex have to Valkyrie2544?
We don't have problems like this when running TRex so I'm confused about why this stuff is here and why these problems are being seen.
There was a problem hiding this comment.
Egads, I thought I had commented on this already - my apologies! Back at the end of August I wrote this README as a "setup from scratch" sort of guide, which presumed the user had nothing already installed or configured. I walked through the process using a fresh Fedora 32 install, and wrote down the bare minimum steps necessary just to get the Xena functionality working.
(At the time of writing the patch) binary-search.py required that a user also install TRex in order to function (as mentioned in a previous comment). But even after installing TRex I still couldn't run binary-search.py due to several crash-inducing errors I'd never seen before. I still don't know why these problems suddenly popped up, but I eventually traced the errors back to the TRex library. Perhaps some update from Cisco unintentionally introduced a bug? I also can't rule out that the problem might have been self-inflicted from some flaw in my install/setup process.
Whatever the cause, I found that binary-search.py would stop crashing (at least enough so that the Xena bits worked) if I made a few tweaks to the TRex install. Hacky? Absolutely. But I lacked the necessary knowledge or skills to sort this problem out (or the time to develop such competencies). So I wrote those workarounds into the README in the hopes they'd be "good-enough" for folks needing to use Xena in the short term, at least while the TRex dependency issues persisted.
TLDR; the TRex changes were just duct tape and will hopefully become unneeded/irrelevant/obsolete and removed as soon as possible.
| if t_global.args.traffic_generator == 'valkyrie2544' and (t_global.args.num_flows < 1 or t_global.args.num_flows > 1000000): | ||
| bs_logger('Please enter a number of flows between 1 and 1000000') | ||
| bs_logger_cleanup(bs_logger_exit, bs_logger_thread) | ||
| return(1) |
There was a problem hiding this comment.
I wonder if we shouldn't make this a generic error that isn't specific to Valkyrie2544...
Adds argument parser option, allows user to specify a particular module of a Xena chassis.
(@ctrautma for reference)