Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-2568 Add gzip compression for indexsearch and lineage endpoints #3574

Merged
merged 12 commits into from
Oct 1, 2024
Merged

PLT-2568 Add gzip compression for indexsearch and lineage endpoints #3574

merged 12 commits into from
Oct 1, 2024

Conversation

sriram-atlan
Copy link

@sriram-atlan sriram-atlan commented Sep 30, 2024 •
edited
Loading

Change description

Add a gzip compression filter and apply it only when client can accept gzip encoding. Compress it when it is available and apply it to only /api/meta/search and /api/meta/lineage endpoints.
80% savings in http traffic between these 2 endpoints. Below is current and with the gzip. (Look at size)

Tested in a Sandbox

Current -> try.atlan.com
image

Sandbox -> gziptest.atlan.com
image

Type of change

Performance fix reducing http transfer size

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

sriram-atlan
sriram-atlan commented Sep 30, 2024
View reviewed changes
webapp/src/main/webapp/WEB-INF/web.xml
<filter-mapping>
<filter-name>gzipFilter</filter-name>
<url-pattern>/api/meta/lineage/*</url-pattern>
<url-pattern>/api/meta/search/*</url-pattern>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can apply this filter to /* but don't want to break anything unknown.

@sriram-atlan sriram-atlan merged commit d9de6c4 into beta Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arniesaha arniesaha Awaiting requested review from arniesaha

@mukcool mukcool Awaiting requested review from mukcool

@mehtaanshul mehtaanshul Awaiting requested review from mehtaanshul

@sumandas0 sumandas0 Awaiting requested review from sumandas0

@muniatl muniatl Awaiting requested review from muniatl

@nikhilbonte21 nikhilbonte21 Awaiting requested review from nikhilbonte21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sriram-atlan